Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      At the moment Ivy code base is using sun standard coding conventions, except for private fields which use an underscore prefix.

      Using the plain standard conventions would help developers read the code more easily, and thus could attract more developers.

      The coding conventions are described here:
      http://java.sun.com/docs/codeconv/html/CodeConvTOC.doc.html

      1. ivy.diff
        19 kB
        Markus M. May

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user twogee closed the pull request at:

          https://github.com/apache/ant-ivy/pull/41

          Show
          githubbot ASF GitHub Bot added a comment - Github user twogee closed the pull request at: https://github.com/apache/ant-ivy/pull/41
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user twogee opened a pull request:

          https://github.com/apache/ant-ivy/pull/41

          Checkstyle

          Now that checkstyle rules are sync'ed with Ant, here come the consequences 😃
          I guess the famous https://issues.apache.org/jira/browse/IVY-511 is due for an update...

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/twogee/ant-ivy checkstyle

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/ant-ivy/pull/41.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #41


          commit 838aa1bd37ff2f60a51c60969204964839937eb9
          Author: twogee <g.grigelionis@gmail.com>
          Date: 2017-06-02T15:37:04Z

          first batch of SVG replacements

          commit 57ee0f2d15768efd10c15c7ef14da8a7db94deaa
          Author: twogee <g.grigelionis@gmail.com>
          Date: 2017-06-03T07:58:10Z

          Inline warning icon

          commit 1ca5f08e25401ad9861d6de333f8e53791384be6
          Author: twogee <g.grigelionis@gmail.com>
          Date: 2017-06-03T09:42:00Z

          Checkstyle-driven cleanup (whitespace, javadoc, JLS)


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/41 Checkstyle Now that checkstyle rules are sync'ed with Ant, here come the consequences 😃 I guess the famous https://issues.apache.org/jira/browse/IVY-511 is due for an update... You can merge this pull request into a Git repository by running: $ git pull https://github.com/twogee/ant-ivy checkstyle Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant-ivy/pull/41.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #41 commit 838aa1bd37ff2f60a51c60969204964839937eb9 Author: twogee <g.grigelionis@gmail.com> Date: 2017-06-02T15:37:04Z first batch of SVG replacements commit 57ee0f2d15768efd10c15c7ef14da8a7db94deaa Author: twogee <g.grigelionis@gmail.com> Date: 2017-06-03T07:58:10Z Inline warning icon commit 1ca5f08e25401ad9861d6de333f8e53791384be6 Author: twogee <g.grigelionis@gmail.com> Date: 2017-06-03T09:42:00Z Checkstyle-driven cleanup (whitespace, javadoc, JLS)
          Hide
          hibou Nicolas Lalevée added a comment -

          closing, this has been done age ago

          Show
          hibou Nicolas Lalevée added a comment - closing, this has been done age ago
          Hide
          xavier Xavier Hanin added a comment -

          I've applied your patch (except for the checkstyle configuration change, too difficult to review). Thanks a lot for your contribution, it's really appreciated!

          Show
          xavier Xavier Hanin added a comment - I've applied your patch (except for the checkstyle configuration change, too difficult to review). Thanks a lot for your contribution, it's really appreciated!
          Hide
          mmay@gmx.net Markus M. May added a comment -

          Added a diff with changes in the Checkstyle configuration as well as changes to different classes to clean up checkstyl error messages.

          Show
          mmay@gmx.net Markus M. May added a comment - Added a diff with changes in the Checkstyle configuration as well as changes to different classes to clean up checkstyl error messages.
          Hide
          xavier Xavier Hanin added a comment -

          We do not assign this issue to one committer only, the whole team is responsible for updating the code incrementally.

          Show
          xavier Xavier Hanin added a comment - We do not assign this issue to one committer only, the whole team is responsible for updating the code incrementally.

            People

            • Assignee:
              Unassigned
              Reporter:
              xavier Xavier Hanin
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development