Uploaded image for project: 'Ivy'
  1. Ivy
  2. IVY-1478

Missing extension in RETRIEVE task in combination with updatesite resolver

    Details

      Description

      Using the updatesite resolver and the retrieve ant task, I do not get the correct filenames in the retrieve destination. The retrieve task cuts away the extension (.jar) of the bundles that I fetched.

      Steps to reproduce:

      Reason of bug:
      org.apache.ivy.core.retrieve.RetrieveEngine:342
      checks against ArtifactDownloadReport.getUnpackedLocalFile() and if present, sets a String representing the extension to EMPTY instead of NULL.

      org.apache.ivy.core.IvyPatternHelper:162
      uses the extension unless set to NULL, in which case "jar" would be correctly used.

      Settings the extension string to EMPTY when ArtifactDownloadReport.getUnpackedLocalFile() returns NOT NULL is IMO wrong when there is only 1 decision for the final extension based on whether the extension string has a value or is NULL, in which case the extension is "jar"

      Possible solution:
      In org.apache.ivy.core.IvyPatternHelper:
      When ArtifactDownloadReport.getUnpackedLocalFile() returns NOT NULL, try to retrieve the extension from the File object OR set the extension to NULL, expecting "jar" as extension (highly risky)

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                hibou Nicolas Lalevée
                Reporter:
                slacky Alexander Ziller
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: