[IVY-1465] ModuleRules.getRule is O(n) leading to resolution slowness

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.3.0
• Fix Version/s: 2.4.0
• Component/s: Core
• Labels: performance

Environment

OpenJDK 6,7, MacOSX + Ubuntu

• Assignee: Unassigned
• Reporter: Joshua Suereth
• Created: 01/Apr/14 19:47
• Updated: 17/Dec/14 10:22
• Resolved: 17/Dec/14 10:17

Description

So, for the sbt project we noticed significant resolution time improvements with the following patch:

https://github.com/sbt/ivy/pull/1

The reasoning:

A lot of artifacts being resolved use Maven's "dependencyManagement" conventions
Ivy appears to turn these into "exact matcher" rules
A ton of resolution time is spent filtering through these rules
The existing solution is O for all overrides

What the patch does:

Creates a key'd store for all "exact matcher" rules
When executing rules, ensure that we only traverse what we have to (non-exact, exact specific to our key and "default").

As I said, this represents a significant speed bump for sbt builds using Ivy. All existing tests pass, and I think they cover this aspect of ivy pretty well, from what I could see.

Issue Links

• is duplicated by: IVY-1496 PomModuleDescriptorBuilder. overwriteExtraInfoIfExists keeps on adding ExtraInfo, whether it's in the cache or not