Ivy
  1. Ivy
  2. IVY-1383

Documentation and Implementation mismatch of makepom

    Details

      Description

      The documentation of the makepom task is not consistent with the implementation.

      Documentation:

      Attribute Description Required
      ... ... ...
      artifactPackaging The packaging of the artifact which is represented by the generated pom file. (since 2.2) No, the artifact ext is taken by default. Defaults to 'pom' if no such artifact is defined.
      ... ... ...

      Implementation:

      PomModuleDescriptorWriter.java
      ...
              String packaging = options.getArtifactPackaging();
              if (packaging == null) {
                  // find artifact to determine the packaging
                  Artifact artifact = findArtifact(md, artifactId);
                  if (artifact == null) {
                      // no suitable artifact found, default to 'pom'
                      packaging = "pom";
                  } else {
                      packaging = artifact.getType();
                                  ^^^^^^^^^^^^^^^^^^
                  }
              }
      ...
      
      1. makepom-doc.patch
        1 kB
        Thomas Kurpick

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        3d 8h 27m 1 Maarten Coene 22/Oct/12 22:19
        Maarten Coene made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Maarten Coene [ maartenc ]
        Fix Version/s 2.3.0 [ 12320743 ]
        Resolution Fixed [ 1 ]
        Hide
        Maarten Coene added a comment -

        Patch applied.
        Thanks a lot for the contribution!

        Show
        Maarten Coene added a comment - Patch applied. Thanks a lot for the contribution!
        Maarten Coene made changes -
        Original Estimate 0.5h [ 1800 ]
        Remaining Estimate 0.5h [ 1800 ]
        Thomas Kurpick made changes -
        Field Original Value New Value
        Attachment makepom-doc.patch [ 12549977 ]
        Hide
        Thomas Kurpick added a comment -

        patch for doc

        Show
        Thomas Kurpick added a comment - patch for doc
        Thomas Kurpick created issue -

          People

          • Assignee:
            Maarten Coene
            Reporter:
            Thomas Kurpick
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development