Ivy
  1. Ivy
  2. IVY-1353

It appears that the ignore circular dependency strategy is clobbering the warn strategy

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.3.0-RC1
    • Fix Version/s: 2.3.0-RC2, 2.4.0-RC1
    • Component/s: Core
    • Labels:

      Description

      In org.apache.ivy.plugins.circular the IgnoreCircularDependencyStrategy class has this constructor:

      private IgnoreCircularDependencyStrategy() {
          super("warn");
      }
      

      Thus is claiming to be the warn strategy and then clobbers the real warn strategy when it is registered in IvySettings.configureDefaultCircularDependencyStrategies()

      I think the fix is to just change the above string to "ignore", so:

      private IgnoreCircularDependencyStrategy() {
          super("ignore");
      }
      

        Activity

        Carl Quinn created issue -
        Carl Quinn made changes -
        Field Original Value New Value
        Description In org.apache.ivy.plugins.circular the IgnoreCircularDependencyStrategy class has this constructor:

            private IgnoreCircularDependencyStrategy() {
                super("warn");
            }

        Thus is claiming to be the warn strategy and then clobbers the real warn strategy when it is registered in IvySettings.configureDefaultCircularDependencyStrategies()

        I think the fix is to just change the above string to "ignore".
        In org.apache.ivy.plugins.circular the IgnoreCircularDependencyStrategy class has this constructor:
        {code}
        private IgnoreCircularDependencyStrategy() {
            super("warn");
        }
        {code}
        Thus is claiming to be the warn strategy and then clobbers the real warn strategy when it is registered in IvySettings.configureDefaultCircularDependencyStrategies()

        I think the fix is to just change the above string to "ignore".
        Carl Quinn made changes -
        Description In org.apache.ivy.plugins.circular the IgnoreCircularDependencyStrategy class has this constructor:
        {code}
        private IgnoreCircularDependencyStrategy() {
            super("warn");
        }
        {code}
        Thus is claiming to be the warn strategy and then clobbers the real warn strategy when it is registered in IvySettings.configureDefaultCircularDependencyStrategies()

        I think the fix is to just change the above string to "ignore".
        In org.apache.ivy.plugins.circular the IgnoreCircularDependencyStrategy class has this constructor:

        {code}
        private IgnoreCircularDependencyStrategy() {
            super("warn");
        }
        {code}
        Thus is claiming to be the warn strategy and then clobbers the real warn strategy when it is registered in IvySettings.configureDefaultCircularDependencyStrategies()

        I think the fix is to just change the above string to "ignore", so:

        {code}
        private IgnoreCircularDependencyStrategy() {
            super("ignore");
        }
        {code}
        Nicolas Lalevée made changes -
        Labels patch
        Hide
        Nicolas Lalevée added a comment -

        Patch applied, thank you.

        Show
        Nicolas Lalevée added a comment - Patch applied, thank you.
        Nicolas Lalevée made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Nicolas Lalevée [ hibou ]
        Fix Version/s 2.3.0 [ 12320743 ]
        Fix Version/s trunk [ 12320744 ]
        Resolution Fixed [ 1 ]
        Maarten Coene made changes -
        Fix Version/s 2.4.0-RC1 [ 12326648 ]
        Fix Version/s trunk [ 12320744 ]

          People

          • Assignee:
            Nicolas Lalevée
            Reporter:
            Carl Quinn
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development