Uploaded image for project: 'Ivy'
  1. Ivy
  2. IVY-1229

makepom ignores the artifact type in generated dependencies

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 2.0, 2.2.0-RC1
    • 2.3.0-RC1
    • Core
    • None

    Description

      The ant task makepom greates a pom.xml that does not hold the information given with the type attribute in the ivy.xml.

      ivy.xml
         ...
          <dependency org="docbook" name="docbook-xsl" rev="1.73.2">
            <artifact name="docbook-xsl" type="zip" />
          </dependency>
         ...
      

      gets

      pom.xml
         ...
          <dependency>
            <groupId>docbook</groupId>
            <artifactId>docbook-xsl</artifactId>
            <version>1.73.2</version>
            <optional>true</optional>
          </dependency>
         ...
      

      I would expect:

      pom.xml
         ...
          <dependency>
            <groupId>docbook</groupId>
            <artifactId>docbook-xsl</artifactId>
            <version>1.73.2</version>
            <type>zip</type>
            <optional>true</optional>
          </dependency>
         ...
      

      Attachments

        1. ivy-1229.patch
          14 kB
          Douglas Palmer

        Activity

          dpalmer Douglas Palmer added a comment -

          Proposed patch to fix this issue. Patch includes a test for this issue.

          dpalmer Douglas Palmer added a comment - Proposed patch to fix this issue. Patch includes a test for this issue.
          dpalmer Douglas Palmer added a comment -

          Sorry, my previous patch was a little naive, this patch will handle multiple artefact elements. It also outputs classifiers where appropriate. Finally it adds a test for both type and classifier.

          dpalmer Douglas Palmer added a comment - Sorry, my previous patch was a little naive, this patch will handle multiple artefact elements. It also outputs classifiers where appropriate. Finally it adds a test for both type and classifier.
          maartenc Maarten Coene added a comment -

          I've applied your in SVN trunk.
          Thank you for the contribution!

          maartenc Maarten Coene added a comment - I've applied your in SVN trunk. Thank you for the contribution!

          People

            maartenc Maarten Coene
            amandel Andreas Mandel
            Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: