Ivy
  1. Ivy
  2. IVY-1229

makepom ignores the artifact type in generated dependencies

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0, 2.2.0-RC1
    • Fix Version/s: 2.3.0-RC1
    • Component/s: Core
    • Labels:
      None

      Description

      The ant task makepom greates a pom.xml that does not hold the information given with the type attribute in the ivy.xml.

      ivy.xml
         ...
          <dependency org="docbook" name="docbook-xsl" rev="1.73.2">
            <artifact name="docbook-xsl" type="zip" />
          </dependency>
         ...
      

      gets

      pom.xml
         ...
          <dependency>
            <groupId>docbook</groupId>
            <artifactId>docbook-xsl</artifactId>
            <version>1.73.2</version>
            <optional>true</optional>
          </dependency>
         ...
      

      I would expect:

      pom.xml
         ...
          <dependency>
            <groupId>docbook</groupId>
            <artifactId>docbook-xsl</artifactId>
            <version>1.73.2</version>
            <type>zip</type>
            <optional>true</optional>
          </dependency>
         ...
      
      1. ivy-1229.patch
        14 kB
        Douglas Palmer

        Activity

        Andreas Mandel created issue -
        Hide
        Douglas Palmer added a comment -

        Proposed patch to fix this issue. Patch includes a test for this issue.

        Show
        Douglas Palmer added a comment - Proposed patch to fix this issue. Patch includes a test for this issue.
        Douglas Palmer made changes -
        Field Original Value New Value
        Attachment ivy-1229.patch [ 12487618 ]
        Hide
        Douglas Palmer added a comment -

        Sorry, my previous patch was a little naive, this patch will handle multiple artefact elements. It also outputs classifiers where appropriate. Finally it adds a test for both type and classifier.

        Show
        Douglas Palmer added a comment - Sorry, my previous patch was a little naive, this patch will handle multiple artefact elements. It also outputs classifiers where appropriate. Finally it adds a test for both type and classifier.
        Douglas Palmer made changes -
        Attachment ivy-1229.patch [ 12487629 ]
        Douglas Palmer made changes -
        Attachment ivy-1229.patch [ 12487618 ]
        Hide
        Maarten Coene added a comment -

        I've applied your in SVN trunk.
        Thank you for the contribution!

        Show
        Maarten Coene added a comment - I've applied your in SVN trunk. Thank you for the contribution!
        Maarten Coene made changes -
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Maarten Coene [ maartenc ]
        Fix Version/s trunk [ 12313426 ]

          People

          • Assignee:
            Maarten Coene
            Reporter:
            Andreas Mandel
          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development