Ivy
  1. Ivy
  2. IVY-1175

ApacheURLLister does not allow directories not containing a dot

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.0-RC1
    • Fix Version/s: 2.2.0-RC1
    • Component/s: Core
    • Labels:
      None

      Description

      I need to use a different revision scheme that looks like R1A01, i.e. not the normal scheme x.y.z, for my company internal dependencies. When doing this, I discovered that ApacheURLLister does not handle directories without a dot (.) properly as it filters those out. If it does not find a dot in the directory name, it compares the href with the text but forgets to check for a trailing slash in href.

      1. artifactory_directory_listing.zip
        120 kB
        Anders Jacobsson
      2. patch.diff
        0.8 kB
        Anders Jacobsson

        Activity

        Hide
        Anders Jacobsson added a comment -

        Added patch based on revision 918275

        Show
        Anders Jacobsson added a comment - Added patch based on revision 918275
        Hide
        Maarten Coene added a comment -

        I tried to create a junit test for your problem, but I wasn't able to reproduce it.
        Could you attach such a html listing that is causing problems?

        Show
        Maarten Coene added a comment - I tried to create a junit test for your problem, but I wasn't able to reproduce it. Could you attach such a html listing that is causing problems?
        Hide
        Anders Jacobsson added a comment -

        I have added a complete HTML dump of a directory listing from Artifactory.

        As you can see, Artifactory does not have a trailing slash on directory entries. And when I think of it, perhaps the title of this bug report is somewhat misleading. It is the combination of not having a dot and not having a trailing slash that is the problem.

        Show
        Anders Jacobsson added a comment - I have added a complete HTML dump of a directory listing from Artifactory. As you can see, Artifactory does not have a trailing slash on directory entries. And when I think of it, perhaps the title of this bug report is somewhat misleading. It is the combination of not having a dot and not having a trailing slash that is the problem.
        Hide
        Maarten Coene added a comment -

        Patch committed in trunk.
        I fixed it a bit differently than the patch you suggested, so please give it a try to check if your problem has been solved.

        thanks for the contribution!
        Maarten

        Show
        Maarten Coene added a comment - Patch committed in trunk. I fixed it a bit differently than the patch you suggested, so please give it a try to check if your problem has been solved. thanks for the contribution! Maarten
        Hide
        Anders Jacobsson added a comment -

        Works perfectly. Thanks for the quick turnaround!

        Show
        Anders Jacobsson added a comment - Works perfectly. Thanks for the quick turnaround!

          People

          • Assignee:
            Maarten Coene
            Reporter:
            Anders Jacobsson
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development