Ivy
  1. Ivy
  2. IVY-1128

SearchEngine.listModules returns MRID without extra attributes.

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.1.0-RC2
    • Fix Version/s: 2.2.0-RC1
    • Component/s: Core
    • Labels:
      None
    • Environment:

      Ivy 2.1.0-rc2 - 20090704004254
      Apache Ant version 1.7.0 compiled on December 13 2006

      Description

      The ModuleRevisionId objects that are returned by the SearchEngine.listModules(ModuleRevisionId, PatternMatcher) method does not contain any extra attributes. If extra attributes are passed in then they should also be added to the returned module. Without the extra attributes then then the modules returned are practically useless for any further use. This method is published in the Ivy class, too.

      See attached for test and fix patch.

      1. IVY-1128b.improvetest.patch
        10 kB
        Michael Scheetz
      2. IVY-1128.fix.svn.patch
        11 kB
        Michael Scheetz

        Activity

        Hide
        Michael Scheetz added a comment -

        SVN patch file contains a test and fix.

        Show
        Michael Scheetz added a comment - SVN patch file contains a test and fix.
        Hide
        Maarten Coene added a comment -

        I've applied a little modified version of your patch into SVN trunk.
        Could you give it a try?

        Thanks!
        Maarten

        Show
        Maarten Coene added a comment - I've applied a little modified version of your patch into SVN trunk. Could you give it a try? Thanks! Maarten
        Hide
        Michael Scheetz added a comment -

        Added more to the repository

        Show
        Michael Scheetz added a comment - Added more to the repository
        Hide
        Michael Scheetz added a comment -

        Maarten,

        The list of modules returned by ivy.listModules(criteria, settings.getMatcher(PatternMatcher.REGEXP)) now contain the extra attributes, so that part is fixed.

        However, the method does not honor all of the search criteria stated by the ModuleRevisionId. That is, the extra attributes are ignored as search parameters. The returned list contains all of the modules that match the "org,name,revision" portion of the mrid. It should return only the modules which match "org,name,revision,extraAtts".

        Michael

        Show
        Michael Scheetz added a comment - Maarten, The list of modules returned by ivy.listModules(criteria, settings.getMatcher(PatternMatcher.REGEXP)) now contain the extra attributes, so that part is fixed. However, the method does not honor all of the search criteria stated by the ModuleRevisionId. That is, the extra attributes are ignored as search parameters. The returned list contains all of the modules that match the "org,name,revision" portion of the mrid. It should return only the modules which match "org,name,revision,extraAtts". Michael
        Hide
        Maarten Coene added a comment -

        ok, I did miss some critical part of your original patch, sorry about that.
        I've now committed an additional change to SVN trunk which should solve the problem, could you please give it a try.

        thanks!
        Maarten

        Show
        Maarten Coene added a comment - ok, I did miss some critical part of your original patch, sorry about that. I've now committed an additional change to SVN trunk which should solve the problem, could you please give it a try. thanks! Maarten
        Hide
        Michael Scheetz added a comment -

        Maarten,

        Yes, this change looks like it worked. Thanks for your help to get this patch (and all of the others) into production.

        Michael

        Show
        Michael Scheetz added a comment - Maarten, Yes, this change looks like it worked. Thanks for your help to get this patch (and all of the others) into production. Michael

          People

          • Assignee:
            Maarten Coene
            Reporter:
            Michael Scheetz
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development