Uploaded image for project: 'Ivy'
  1. Ivy
  2. IVY-1120

IvyBuildNumber non-deterministic behaviour

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.1.0-RC2
    • Fix Version/s: 2.2.0-RC1
    • Component/s: Ant
    • Labels:
      None
    • Environment:

      ant 1.7.1, windows xp

      Description

      IvyBuildNumber.java -> doExecute()

      creates an inline patternMatcher with this method:

      IvyBuildNumber.java
      public Matcher getMatcher(String expression) {
                      if ((expression == organisation)
                              || (expression == module)
                              || (expression == branch)) {
                          return exact.getMatcher(expression);
                      }
                      return regexp.getMatcher(expression);
                  }
      

      I'm guessing the == comparison is a typo ? Shouldn't it be saying .equals ?
      I've been having issues with this task - non-deterministic results - I got down in my debug to this place where I get wrong matcher when
      reference address comparison fails.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                maartenc Maarten Coene
                Reporter:
                gibffe Lucas Lech
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: