Uploaded image for project: 'Ivy'
  1. Ivy
  2. IVY-1118

IvyNodeEviction.cleanEvicted has bad comparison logic

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 2.1.0-RC2
    • 2.2.0-RC1
    • Core
    • None

    Description

      clean evicted compares an IvyNode to an IvyNodeEviction which will always be false

      private void cleanEvicted() {
      // check if it was evicted by a node that we are now the real node for
      for (Iterator iter = evicted.keySet().iterator(); iter.hasNext() {
      String rootModuleConf = (String) iter.next();
      EvictionData ed = (EvictionData) evicted.get(rootModuleConf);
      Collection sel = ed.getSelected();
      if (sel != null) {
      for (Iterator iterator = sel.iterator(); iterator.hasNext() {
      IvyNode n = (IvyNode) iterator.next();
      if (n.getRealNode().equals(this))

      { <<<<<<<<<<<<<<<<<<<<<<<< // yes, we are the real node for a selected one ! // we are no more evicted in this conf ! iter.remove(); }

      }
      }
      }
      }

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            maartenc Maarten Coene
            dbrosius David Brosius
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Issue deployment