Ivy
  1. Ivy
  2. IVY-1118

IvyNodeEviction.cleanEvicted has bad comparison logic

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.0-RC2
    • Fix Version/s: 2.2.0-RC1
    • Component/s: Core
    • Labels:
      None

      Description

      clean evicted compares an IvyNode to an IvyNodeEviction which will always be false

      private void cleanEvicted() {
      // check if it was evicted by a node that we are now the real node for
      for (Iterator iter = evicted.keySet().iterator(); iter.hasNext() {
      String rootModuleConf = (String) iter.next();
      EvictionData ed = (EvictionData) evicted.get(rootModuleConf);
      Collection sel = ed.getSelected();
      if (sel != null) {
      for (Iterator iterator = sel.iterator(); iterator.hasNext() {
      IvyNode n = (IvyNode) iterator.next();
      if (n.getRealNode().equals(this))

      { <<<<<<<<<<<<<<<<<<<<<<<< // yes, we are the real node for a selected one ! // we are no more evicted in this conf ! iter.remove(); }

      }
      }
      }
      }

        Activity

        Dave Brosius created issue -
        Hide
        Maarten Coene added a comment -

        Fixed in SVN trunk.
        Thanks for reporting this!

        Maarten

        Show
        Maarten Coene added a comment - Fixed in SVN trunk. Thanks for reporting this! Maarten
        Maarten Coene made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Maarten Coene [ maartenc ]
        Fix Version/s trunk [ 12313426 ]
        Resolution Fixed [ 1 ]
        Maarten Coene made changes -
        Fix Version/s 2.2.0-RC1 [ 12315013 ]
        Fix Version/s trunk [ 12313426 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        51d 9h 1 Maarten Coene 23/Oct/09 23:09

          People

          • Assignee:
            Maarten Coene
            Reporter:
            Dave Brosius
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development