Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-RC2
    • Fix Version/s: 2.2.0
    • Component/s: Ant
    • Labels:
      None

      Description

      <makepom ...>
        <mapping conf="test" nowhere="true"/>
      </makepom>
      

      So all dependencies in configuration "test" will not present in generated pom.xml.

        Activity

        Stepan Koltsov created issue -
        Jesper Pedersen made changes -
        Field Original Value New Value
        Attachment IVY-1005.patch [ 12449120 ]
        Jesper Pedersen made changes -
        Attachment IVY-1005.patch [ 12449120 ]
        Jesper Pedersen made changes -
        Attachment IVY-1005.patch [ 12449244 ]
        Hide
        Maarten Coene added a comment -

        Sorry for the late response, but to make this task more consistent with the other Ivy tasks, I think we should add a "conf" attribute to the "makepom" element to allow you to specify which configurations should be included. This attribute would default to "*".

        So if the module has 3 configurations (default,runtime,test) and we want to exclude the test configuration, we could have somehting like:

        <ivy:makepom ivyfile="${basedir}/path/to/ivy.xml" pomfile="${basedir}/path/to/module.pom" conf="default,runtime">
           <mapping conf="default" scope="compile"/>
           <mapping conf="runtime" scope="runtime"/>
        </ivy:makepom>
        
        Show
        Maarten Coene added a comment - Sorry for the late response, but to make this task more consistent with the other Ivy tasks, I think we should add a "conf" attribute to the "makepom" element to allow you to specify which configurations should be included. This attribute would default to "*". So if the module has 3 configurations (default,runtime,test) and we want to exclude the test configuration, we could have somehting like: <ivy:makepom ivyfile= "${basedir}/path/to/ivy.xml" pomfile= "${basedir}/path/to/module.pom" conf= "default,runtime" > <mapping conf= "default" scope= "compile" /> <mapping conf= "runtime" scope= "runtime" /> </ivy:makepom>
        Jesper Pedersen made changes -
        Attachment IVY-1005.patch [ 12449244 ]
        Hide
        Jesper Pedersen added a comment -

        Yeah, that is more clear. I have changed my patch to the above, but it is included in IVY-770 atm

        Show
        Jesper Pedersen added a comment - Yeah, that is more clear. I have changed my patch to the above, but it is included in IVY-770 atm
        Hide
        Maarten Coene added a comment -

        I've extracted the necessary changes to fix this issue from your patch attached to IVY-770.
        I've also modified it a bit to take configuration inheritance into account.

        Could you give it a try? (if possible because the other changes for IVY-770 hasn't been committed yet)

        Show
        Maarten Coene added a comment - I've extracted the necessary changes to fix this issue from your patch attached to IVY-770 . I've also modified it a bit to take configuration inheritance into account. Could you give it a try? (if possible because the other changes for IVY-770 hasn't been committed yet)
        Maarten Coene made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Maarten Coene [ maartenc ]
        Fix Version/s trunk [ 12313426 ]
        Resolution Fixed [ 1 ]
        Maarten Coene made changes -
        Fix Version/s 2.2.0 [ 12315188 ]
        Fix Version/s trunk [ 12313426 ]
        Hide
        Jesper Pedersen added a comment -

        I think you changed too much - doesn't work here with scope attribute. Packaging also doesn't work - but that is a IVY-770 concern.

        I'll sync and update my patch for IVY-770.

        Show
        Jesper Pedersen added a comment - I think you changed too much - doesn't work here with scope attribute. Packaging also doesn't work - but that is a IVY-770 concern. I'll sync and update my patch for IVY-770 .

          People

          • Assignee:
            Maarten Coene
            Reporter:
            Stepan Koltsov
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development