[CAUSEWAY-884] ErrorPage vulnerable to XSS attacks.

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: viewer-wicket-1.6.0
• Fix Version/s: viewer-wicket-1.7.0
• Component/s: Viewer Wicket
• Assignee: Unassigned
• Reporter: Daniel Keir Haywood
• Created: 10/Sep/14 14:45
• Updated: 21/Oct/14 05:55
• Resolved: 11/Sep/14 13:58

Description

The default error page (org.apache.isis.viewer.wicket.ui.pages.error.ErrorPage) is vulnerable to XSS via org.apache.isis.viewer.wicket.ui.errors.ExceptionStackTracePanel

In the constructor of ExceptionStackTracePanel, it adds a Label with the exception message and calls setEscapeModelStrings(false)

This means any URL that a URL be constructed to reference an entity with Javascript inserted where the OID should be and an exception is thrown with the Javascript code inserted in to the message.

This is then written to the page un-escaped to be executed in the users session.

It is made worse by the bookmarkable feature (I think that's what does this), where an attacker can navigate to a crafted URL on a user's PC, if they don't close all of their browser windows before the session times out, when they log in they will be redirected to the crafted URL.