[IO-705] MarkShieldInputStream#reset should throw UnsupportedOperationException

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.9.0
• Assignee: Gary D. Gregory
• Reporter: Hao Zhong
• Created: 20/Jan/21 05:18
• Updated: 21/Jan/21 15:06
• Resolved: 21/Jan/21 15:06

Description

The code of MarkShieldInputStream#reset is as follows:

 public void reset() throws IOException {
        throw new IOException("mark/reset not supported");
    }

The message indicates that it is better to throw UnsupportedOperationException. Indeed, otehr classes throw that exception in similar contexts:

WindowsLineEndingInputStream#mark

 public synchronized void mark(final int readlimit) {
        throw new UnsupportedOperationException("Mark not supported");
    }

NullReader#reset:

public synchronized void reset() throws IOException {
        if (!markSupported) {
            throw new UnsupportedOperationException("Mark not supported");
        }
        if (mark < 0) {
            throw new IOException("No position has been marked");
        }
        if (position > mark + readlimit) {
            throw new IOException("Marked position [" + mark +
                    "] is no longer valid - passed the read limit [" +
                    readlimit + "]");
        }
        position = mark;
        eof = false;
    }