[IO-696] IOUtils.toByteArray throws inconsistent exceptions

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.9.0
• Assignee: Unassigned
• Reporter: ackelcn
• Created: 29/Dec/20 00:17
• Updated: 15/Feb/21 13:45
• Resolved: 15/Feb/21 13:45

Description

The code of this method is as follows:

public static byte[] toByteArray(final InputStream input, final int size) throws IOException {        

      if (size < 0) {
            throw new IllegalArgumentException("Size must be equal or greater than zero: " + size);
        }        if (size == 0) {
            return new byte[0];
        }        final byte[] data = new byte[size];
        int offset = 0;
        int read;        while (offset < size && (read = input.read(data, offset, size - offset)) != EOF) {
            offset += read;
        }        
        if (offset != size) {
            throw new IOException("Unexpected read size. current: " + offset + ", expected: " + size);
        }        return data;
    }

When size is below zero, it throws IllegalArgumentException, but when size is not equal to offset, it throws IOException. It is somewhat confusing. It shall throw IOException in both cases, in that both cases check legal sizes.