[IO-683] CircularBufferInputStream.read() fails to convert byte to unsigned int

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.8.0
• Assignee: Sebb
• Reporter: Sebb
• Created: 10/Aug/20 20:25
• Updated: 10/Aug/20 21:39
• Resolved: 10/Aug/20 21:00

Description

The method int CircularBufferInputStream.read() returns CircularByteBuffer.read() which a byte.

However it does not convert it to an unsigned byte, so byte values outside the range 0-127 will be sign-extended to a negative value.

This is wrong, and can result in premature EOF.

Note: this bug was reported by Sonarlint.
Spotbugs does not appear to detect the bug.