[IO-651] Provide method to retrieve data from DeferredFileOutputStream as InputStream

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.6
• Fix Version/s: 2.9.0
• Component/s: Streams/Writers
• Labels: easyfix performance pull-request-available
• Flags: Patch
• Assignee: Unassigned
• Reporter: John Mark
• Created: 12/Feb/20 16:45
• Updated: 23/Feb/21 04:02
• Resolved: 22/Feb/21 20:06

Description

It would be very helpful to have to toInputStream() method on the DeferredFileOutputStream class. Besides for convenience, it would allow for improved efficiency since in the case of in-memory data the byte buffer would not need to be copied (as opposed to the current getData() method).

The implementation is pretty simple and can be something like the following (based on the current writeTo(OutputStream) method):

public InputStream toInputStream() throws IOException {
    if (!closed) {
        throw new IOException("Stream not closed");
    }

    if (isInMemory()) {
        return memoryOutputStream.toInputStream();
    } else {
        return Files.newInputStream(outputFile.toPath());
    }
}