[IO-542] FileUtils#readFileToByteArray: optimize reading of files with known size

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.6
• Assignee: Pascal Schumacher
• Reporter: Pascal Schumacher
• Created: 02/Jul/17 15:05
• Updated: 20/Oct/17 06:49
• Resolved: 02/Jul/17 15:12

Description

IO-251 added optimization for reading files with known size as byte arrays, but it was reverted in IO-453 due to regression, because File.length() method may return 0 for path files denoting system-dependent entities such as devices or pipes

More optimal solution is to treat 0 as unknown size and use IOUtils.toByteArray(input), but if size is known (> 0) use more efficient approach and read content into pre-allocated byte array with exact size by calling IOUtils.toByteArray(input, size).

source https://github.com/apache/commons-io/pull/38