[IO-447] Possible NPE in FileSystemUtils.freeSpaceWindows; FilenameUtils.normalize can return null - ASF JIRA

Attach files

Attach Screenshot

Voters

Watch issue

Watchers

Create sub-task

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: None
Component/s: None
Labels:
None

Description

There is a possible NPE in FileSystemUtils.freeSpaceWindows.
FilenameUtils.normalize can return null so the path.length() will NPE

For example, ".." returns null.

I'm not entirely sure why the path needs to be normalised, apart from converting / to \. Even that seems a bit dubious - why should the user want to return the freespace for a Unix-style path on a Windows system?

And if it does need to be normalised, why not use the File class, which handles / to \ conversion transparently?

A short term fix would be to return IAE for paths that normalise to null.
However that would not allow the use of paths such as ".." - though at least that would not cause NPE.