[IO-405] Support threshold=0 in ThresholdingOutputStream

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.5
• Fix Version/s: 2.16.0
• Component/s: Streams/Writers
• Assignee: Jochen Wiedmann
• Reporter: Jochen Wiedmann
• Created: 05/Nov/13 11:45
• Updated: 10/Feb/24 14:44
• Resolved: 10/Feb/24 14:44

Description

I recently had a case where I would wish threshold=0 to trigger an immediate thresholdReached() in ThresholdingOutputStream(). This seems to me to be a natural expectation. However, thresholdReached() is only triggered after the first byte has been written.

I'd like to modify the constructor of ThresholdingOutputStream() in that sense. However, as thresholdReached() might throw an IOException, there are two possibilities I'd like to discuss:

1.) Pass the IOException through. Or, in other words: Modify the constructor to throw an IOException. (Slight binary incompatibility.)
2.) Catch the IOException, pass on a RuntimeException. Source code compatibility, but surprising for the developer.

Personally, I'm in favour for 1.)

Issue Links

• links to: GitHub Pull Request #587