[IO-136] HexDump's use of static StringBuffers isn't thread-safe

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.3.2
• Fix Version/s: 1.4
• Assignee: Niall Pemberton
• Reporter: Niall Pemberton
• Created: 20/Nov/07 12:08
• Updated: 22/Aug/08 07:36
• Resolved: 20/Nov/07 12:36

Description

HexDump has two private static dump() method's that alter static instances of StringBuffer:

dump(long) modifies static StringBuffer variable _lbuffer returning _lbuffer
dump(char) modifies static StringBuffer variable _cbuffer returning _cbuffer

Both these methods are called by the public static dump(byte[], long, OutputStream, int) method. Multiple threads calling the public dump method at the same time could cause these StringBuffer to contain mixed up data and result in a bug.