[INLONG-96] Fix typo & use IllegalArgumentException

• Type: Improvement
• Status: Closed
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 0.5.0
• Labels: pull-request-available
• Assignee: Guo Jiwei
• Reporter: Guo Jiwei
• Created: 10/May/20 04:42
• Updated: 28/Jul/21 11:19
• Resolved: 11/May/20 03:29

Description

1. Fix typo
validConsumerGroupParmeter -> validConsumerGroupParameter
pushIsListenerWaitTimeoutRollBack -> pushListenerWaitTimeoutRollBack
pushIsListenerThrowedRollBack -> pushListenerThrowedRollBack

2. Use IllegalArgumentException
In ConsumerConfig#validConsumerGroupParameter

private void validConsumerGroupParameter(String consumerGroup) throws Exception {
        if (TStringUtils.isBlank(consumerGroup)) {
            throw new Exception("Illegal parameter: consumerGroup is Blank!");
        }
        String tmpConsumerGroup = String.valueOf(consumerGroup).trim();
        if (tmpConsumerGroup.length() > TBaseConstants.META_MAX_GROUPNAME_LENGTH) {
            throw new Exception(new StringBuilder(512)
                    .append("Illegal parameter: the max length of consumerGroup is ")
                    .append(TBaseConstants.META_MAX_GROUPNAME_LENGTH)
                    .append(" characters").toString());
        }
        if (!tmpConsumerGroup.matches(TBaseConstants.META_TMP_GROUP_VALUE)) {
            throw new Exception(new StringBuilder(512)
                    .append("Illegal parameter: the value of consumerGroup")
                    .append(" must begin with a letter, ")
                    .append("can only contain characters,numbers,hyphen,and underscores").toString());
        }
    }

will change to throw IllegalArgumentException

private void validConsumerGroupParameter(String consumerGroup) throws Exception {
        if (TStringUtils.isBlank(consumerGroup)) {
            throw new IllegalArgumentException("Illegal parameter: consumerGroup is Blank!");
        }
        String tmpConsumerGroup = String.valueOf(consumerGroup).trim();
        if (tmpConsumerGroup.length() > TBaseConstants.META_MAX_GROUPNAME_LENGTH) {
            throw new IllegalArgumentException(new StringBuilder(512)
                    .append("Illegal parameter: the max length of consumerGroup is ")
                    .append(TBaseConstants.META_MAX_GROUPNAME_LENGTH)
                    .append(" characters").toString());
        }
        if (!tmpConsumerGroup.matches(TBaseConstants.META_TMP_GROUP_VALUE)) {
            throw new IllegalArgumentException(new StringBuilder(512)
                    .append("Illegal parameter: the value of consumerGroup")
                    .append(" must begin with a letter, ")
                    .append("can only contain characters,numbers,hyphen,and underscores").toString());
        }
    }

Issue Links

• links to: GitHub Pull Request #73
• links to: GitHub Pull Request #695