Uploaded image for project: 'Apache InLong'
  1. Apache InLong
  2. INLONG-90

Remove unused codes in TubeBroker

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Normal
    • Resolution: Fixed
    • None
    • 0.5.0
    • None

    Description

      1. TubeBroker implements Runnable interface, I think this is a little strange. If we have some extra work to do , we can create inner thread for it.
      2. JVMClusterUtil is useless . If we support start more than one broker in one JVM, we have to change some params, we can't set different params for different brokers at the same time. And as we will support docker in the future, we decide to remove this class.
      3. remove synchronized in start method.
      4. remove below codes in stop method

      if (this.shutdown.get()) {
          return;
      }
      

      5. remove unused run method.
      6. remove unused waitForServerOnline method.

      Attachments

        Activity

          People

            technoboy Guo Jiwei
            technoboy Guo Jiwei
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 20m
                20m