[IMPALA-9721] Fix python 3 compatibility regression in impala-shell

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: Impala 4.0.0, Impala 3.4.1
• Component/s: Clients
• Epic Color: ghx-label-13
• Assignee: David Knupp
• Reporter: David Knupp
• Created: 02/May/20 03:22
• Updated: 05/Feb/21 13:21
• Resolved: 05/May/20 02:23

Description

The fix for IMPALA-9398 introduced a small regression with regard to python 3 compatibility. We don't have python 3 tests yet to catch regression of this this type, and it was missed in code review.

The regression happens in two places. An example is:
https://github.com/apache/impala/blob/master/shell/impala_shell.py#L248

The syntax for catching exceptions has changed in python 3 to require the "as" keyword.

try:
  do_stuff()
except <exception> as e:
  panic()

Issue Links

• blocks: IMPALA-3343 Impala-shell compatibility with python 3