Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-9721

Fix python 3 compatibility regression in impala-shell

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • Impala 4.0.0, Impala 3.4.1
    • Clients
    • None
    • ghx-label-13

    Description

      The fix for IMPALA-9398 introduced a small regression with regard to python 3 compatibility. We don't have python 3 tests yet to catch regression of this this type, and it was missed in code review.

      The regression happens in two places. An example is:
      https://github.com/apache/impala/blob/master/shell/impala_shell.py#L248

      The syntax for catching exceptions has changed in python 3 to require the "as" keyword.

      try:
        do_stuff()
      except <exception> as e:
        panic()
      

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            dknupp David Knupp
            dknupp David Knupp
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment