Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-9721

Fix python 3 compatibility regression in impala-shell

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: Impala 4.0, Impala 3.4.1
    • Component/s: Clients
    • Labels:
      None
    • Epic Color:
      ghx-label-13

      Description

      The fix for IMPALA-9398 introduced a small regression with regard to python 3 compatibility. We don't have python 3 tests yet to catch regression of this this type, and it was missed in code review.

      The regression happens in two places. An example is:
      https://github.com/apache/impala/blob/master/shell/impala_shell.py#L248

      The syntax for catching exceptions has changed in python 3 to require the "as" keyword.

      try:
        do_stuff()
      except <exception> as e:
        panic()
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                dknupp David Knupp
                Reporter:
                dknupp David Knupp
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: