[IMPALA-9100] tests/run-tests.py should handle duplicate --skip-stress flags

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: Impala 3.4.0
• Fix Version/s: Impala 3.4.0
• Component/s: Infrastructure
• Epic Color: ghx-label-11
• Assignee: Joe McDonnell
• Reporter: Joe McDonnell
• Created: 28/Oct/19 23:14
• Updated: 22/Nov/19 19:25
• Resolved: 22/Nov/19 19:25

Description

If you pass --skip-stress multiple times to tests/run-tests.py, only the first is removed before the arguments are passed to pytest:

  skip_stress = '--skip-stress' in sys.argv
  if skip_stress:
    sys.argv.remove("--skip-stress")

This is also true for skip_serial and skip_parallel.

This matters for the docker-based tests, because the docker-based tests run the serial end-to-end tests with --skip-stress specified. run-all-tests.sh also adds a --skip-stress argument when running core tests:

if [[ "${EXPLORATION_STRATEGY}" == "core" ]]; then
  # Skip the stress test in core - all stress tests are in exhaustive and
  # pytest startup takes a significant amount of time.
  RUN_TESTS_ARGS+=" --skip-stress"
fi

Only one skip-stress is removed, and the other one gets passed to pytest, which immediately fails without running tests.