[IMPALA-9028] Impala shell should not try to reconnect when quitting

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Impala 3.4.0
• Fix Version/s: Impala 3.4.0
• Component/s: Clients
• Labels: shell
• Target Version: Impala 3.4.0
• Epic Color: ghx-label-12
• Assignee: Joe McDonnell
• Reporter: Joe McDonnell
• Created: 08/Oct/19 22:17
• Updated: 16/Oct/19 03:28
• Resolved: 16/Oct/19 03:28

Description

When the impala-shell is not connected, it will try to reconnect when executing a new command (in precmd).

https://github.com/apache/impala/blob/master/shell/impala_shell.py#L600-L603

if not self.imp_client.is_connected():
   print_to_stderr("Connection lost, reconnecting...")
   self._connect()
   self._validate_database(immediately=True)

This doesn't make sense if the user is quitting the shell (by typing 'quit', 'exit', or hitting Ctrl-D). It should skip the reconnect in this case.