[IMPALA-8896] alterPartitionsWithTransaction() emits too many alter table operations

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: Impala 3.4.0
• Epic Color: ghx-label-13
• Assignee: Zoltán Borók-Nagy
• Reporter: Zoltán Borók-Nagy
• Created: 27/Aug/19 10:02
• Updated: 04/Sep/19 15:13
• Resolved: 04/Sep/19 15:13

Description

alterPartitionsWithTransaction() has a for loop that updates the write ids of the partitions.

Unfortunately it also does an RPC inside the for loop that updates all partitions. This could be done outside of the for loop.

  public static void alterPartitionsWithTransaction(IMetaStoreClient client,
      String dbName, String tblName, List<Partition> partitions, TblTransaction tblTxn
      ) throws InvalidOperationException, MetaException, TException {
    for (Partition part : partitions) {
      part.setWriteId(tblTxn.writeId);
      // Correct validWriteIdList is needed
      // to commit the alter partitions operation in hms side.
      client.alter_partitions(dbName, tblName, partitions, null,
           tblTxn.validWriteIds, tblTxn.writeId);
    }
  }