Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-8626

JDBC tests don't seem to be using HTTP

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Not A Problem
    • Affects Version/s: Impala 3.3.0
    • Fix Version/s: None
    • Component/s: Infrastructure
    • Labels:
      None

      Description

      I noticed that the parameterized JDBC tests are passing on the dockerised cluster, which shouldn't be possible because IMPALA-8623 isn't done.

      https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/453/testReport/org.apache.impala.service/JdbcTest/

      The connection strings look identical in both cases:

      19/06/05 13:10:04 INFO testutil.ImpalaJdbcClient: Connecting to: jdbc:hive2://localhost:21050/default;auth=noSasl
      
      19/06/05 13:10:04 INFO testutil.ImpalaJdbcClient: Connecting to: jdbc:hive2://localhost:21050/default;auth=noSasl
      

      I was looking at related code and saw some misuse of == vs equals() for string comparison here https://github.com/apache/impala/blob/master/fe/src/test/java/org/apache/impala/testutil/ImpalaJdbcClient.java#L172

        private static String getConnectionStr(String connType, String authStr) {
          String connString = DEFAULT_CONNECTION_TEMPLATE + authStr;
          if (connType == "binary") {
            return String.format(connString, HS2_BINARY_PORT);
          } else {
            Preconditions.checkState(connType == "http");
            return String.format(connString + HTTP_TRANSPORT_SPEC, HS2_HTTP_PORT);
          }
      }
      

      But I don't think that explains what I'm seeing above.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                twmarshall Thomas Tauber-Marshall
                Reporter:
                tarmstrong Tim Armstrong
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: