[IMPALA-8572] Move query hook execution to before query unregistration

• Type: Sub-task
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: Impala 3.4.0
• Component/s: Backend
• Epic Color: ghx-label-5
• Assignee: Bharath Vissapragada
• Reporter: radford nguyen
• Created: 22/May/19 17:31
• Updated: 16/Sep/19 17:05
• Resolved: 12/Sep/19 04:33

Description

The backend currently executes query event hooks during ImpalaServer::UnregisterQuery, which may actually only happen a long time after the query has actually executed. We depend on either the client closing the query/session, the client's connection dropping, or an idle session timing out.

e.g. the following sequence is possible.

1. User executes query from Hue.
2. User goes home for weekend, leaving Hue tab open in browser
3. If we're lucky, the session timeout expires after some amount of idle time.
4. The query gets unregistered, hooks get executed

It would generally be desirable to move the lineage logger earlier in the query lifecycle, so it occurs as soon as all of the required data is available.

Issue Links

• is caused by: IMPALA-8473 Refactor lineage publication mechanism to allow for different consumers