[IMPALA-844] Not all Thrift exceptions are caught

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Impala 1.2.3
• Fix Version/s: Impala 1.3
• Assignee: Henry Robinson
• Reporter: Henry Robinson
• Created: 28/Feb/14 00:19
• Updated: 05/Mar/14 23:24
• Resolved: 05/Mar/14 23:24

Description

We idiomatically do this for Thrift RPCs:

try {
  client->DoSomeRpc(...);
} catch (const TTransportException& e) {
  // Retry
}

Thrift can throw TApplicationException as well (see e.g. recv_* for any method). We don't catch it, and therefore can abort on the rare occasion it gets thrown. Instead we should catch TException.