[IMPALA-8271] Refactor the use of Thrift enums in query-options.cc

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: Impala 3.3.0
• Component/s: Backend
• Labels: ramp-up
• Epic Color: ghx-label-3
• Assignee: Fredy Wijaya
• Reporter: Fredy Wijaya
• Created: 01/Mar/19 23:09
• Updated: 14/Mar/19 23:17
• Resolved: 14/Mar/19 22:54

Description

Currently the logic for handling Thrift enums in query-options is very error-prone. A change in Thrift enums require updating query-options.cc. For example: https://github.com/apache/impala/blob/master/be/src/service/query-options.cc#L276-L288. This CR: https://gerrit.cloudera.org/c/12635/ is an attempt to fix such issue for compression_codec.

This ticket aims to update the use of Thrift enums with the style similar to: https://gerrit.cloudera.org/c/12635/ to make it less error-prone.