Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-8271

Refactor the use of Thrift enums in query-options.cc

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: Impala 3.3.0
    • Component/s: Backend
    • Labels:
    • Epic Color:
      ghx-label-3

      Description

      Currently the logic for handling Thrift enums in query-options is very error-prone. A change in Thrift enums require updating query-options.cc. For example: https://github.com/apache/impala/blob/master/be/src/service/query-options.cc#L276-L288. This CR: https://gerrit.cloudera.org/c/12635/ is an attempt to fix such issue for compression_codec.

      This ticket aims to update the use of Thrift enums with the style similar to: https://gerrit.cloudera.org/c/12635/ to make it less error-prone.

        Attachments

          Activity

            People

            • Assignee:
              fredyw Fredy Wijaya
              Reporter:
              fredyw Fredy Wijaya
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: