[IMPALA-8236] Adding new TUnit values to runtime profile is broken

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: Impala 2.12.0, Impala 3.1.0
• Component/s: Backend
• Labels: observability
• Target Version: Product Backlog
• Epic Color: ghx-label-8
• Assignee: Unassigned
• Reporter: Tim Armstrong
• Created: 21/Feb/19 01:47
• Updated: 21/Feb/19 02:32

Description

See IMPALA-8235 for context.

The problem this tracks is that there's no way to add a new value to the TUnit enum, which is required in TCounter, without breaking existing readers (at least Java readers), which will fail to decode TCounter values with an enum value they don't recognise.

The workaround is to only use the following units in anything that is serialised into a TCounter:

  UNIT,
  UNIT_PER_SECOND,
  CPU_TICKS,
  BYTES
  BYTES_PER_SECOND,
  TIME_NS,
  DOUBLE_VALUE

Issue Links

• relates to: IMPALA-8235 AdmissionControlTimeSinceLastUpdate TIME_MS counter breaks some profile consumers