[IMPALA-7894] Parser does not catch double overflow

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Impala 3.0
• Component/s: Frontend
• Epic Color: ghx-label-7
• Assignee: Paul Rogers
• Reporter: Paul Rogers
• Created: 27/Nov/18 00:42
• Updated: 02/Jan/19 11:23
• Resolved: 29/Dec/18 00:02

Description

The test case ParserTest.TestNumericLiteralMinMaxValues() incorrectly expects success on DOUBLE constant overflow and underflow:

    ParsesOk(String.format("select %s1", Double.toString(Double.MIN_VALUE)));
    ParsesOk(String.format("select %s1", Double.toString(Double.MAX_VALUE)));

These values are actually out of range as tested by NumericLiteral.analyzeImpl(). However, the parser uses a code path that bypasses this check.

Expected that the above tests will fail, not succeed.

Issue Links

• Is contained by: IMPALA-7902 Revise NumericLiteral to avoid analysis, fix multiple issues