Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-7810

query-state.cc:295] Check failed: profile_buf == nullptr

Agile BoardAttach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      Apparently, some custom cluster tests hit the following DCHECK in QueryState::ConstructReport(). This is a bad DCHECK which was supposed to be removed after the refactoring in that function during the revision in the last couple of iterations of review.

          // Debug action to simulate failure to serialize the profile.
          if (!DebugAction(query_options(), "REPORT_EXEC_STATUS_PROFILE").ok()) {
            DCHECK(profile_buf == nullptr);
            return;
          }
      

      Anyhow, this is accidentally fixed in the patch of IMPALA-4063 as the offending DCHECK is removed from that patch. The fix of IMPALA-4063 is being merged now.

      #0  0x00007f2d7ebde1f7 in raise () from /lib64/libc.so.6
      #1  0x00007f2d7ebdf8e8 in abort () from /lib64/libc.so.6
      #2  0x000000000451c8e4 in google::DumpStackTraceAndExit() ()
      #3  0x000000000451333d in google::LogMessage::Fail() ()
      #4  0x0000000004514be2 in google::LogMessage::SendToLog() ()
      #5  0x0000000004512d17 in google::LogMessage::Flush() ()
      #6  0x00000000045162de in google::LogMessageFatal::~LogMessageFatal() ()
      #7  0x0000000001eea5a7 in impala::QueryState::ConstructReport (this=0xf86a800, done=false, status=..., fis=0xee01b00, report=0x7f2cdabce200, serializer=0x7f2cdabce1c0, profile_buf=0x7f2cdabce338, profile_len=0x7f2cdabce334) at /data/jenkins/workspace/impala-private-parameterized/repos/Impala/be/src/runtime/query-state.cc:295
      #8  0x0000000001eeacfe in impala::QueryState::ReportExecStatusAux (this=0xf86a800, done=false, status=..., fis=0xee01b00, instances_started=true) at /data/jenkins/workspace/impala-private-parameterized/repos/Impala/be/src/runtime/query-state.cc:334
      #9  0x0000000001eea20d in impala::QueryState::ReportExecStatus (this=0xf86a800, done=false, status=..., fis=0xee01b00) at /data/jenkins/workspace/impala-private-parameterized/repos/Impala/be/src/runtime/query-state.cc:261
      #10 0x0000000001ee0600 in impala::FragmentInstanceState::SendReport (this=0xee01b00, done=false, status=...) at /data/jenkins/workspace/impala-private-parameterized/repos/Impala/be/src/runtime/fragment-instance-state.cc:408
      #11 0x0000000001edfed5 in impala::FragmentInstanceState::ReportProfileThread (this=0xee01b00) at /data/jenkins/workspace/impala-private-parameterized/repos/Impala/be/src/runtime/fragment-instance-state.cc:389
      #12 0x0000000001edc339 in impala::FragmentInstanceState::<lambda()>::operator()(void) const (__closure=0x7f2cdabceba8) at /data/jenkins/workspace/impala-private-parameterized/repos/Impala/be/src/runtime/fragment-instance-state.cc:246
      #13 0x0000000001ee2219 in boost::detail::function::void_function_obj_invoker0<impala::FragmentInstanceState::Prepare()::<lambda()>, void>::invoke(boost::detail::function::function_buffer &) (function_obj_ptr=...) at /data/jenkins/workspace/impala-private-parameterized/Impala-Toolchain/boost-1.57.0-p3/include/boost/function/function_template.hpp:153
      #14 0x0000000001d0595c in boost::function0<void>::operator() (this=0x7f2cdabceba0) at /data/jenkins/workspace/impala-private-parameterized/Impala-Toolchain/boost-1.57.0-p3/include/boost/function/function_template.hpp:767
      #15 0x0000000002185773 in impala::Thread::SuperviseThread(std::string const&, std::string const&, boost::function<void ()>, impala::ThreadDebugInfo const*, impala::Promise<long, (impala::PromiseMode)0>*) (name=..., category=..., functor=..., parent_thread_info=0x7f2cdc3d1850, thread_started=0x7f2cdc3d0b90) at /data/jenkins/workspace/impala-private-parameterized/repos/Impala/be/src/util/thread.cc:359
      #16 0x000000000218da93 in boost::_bi::list5<boost::_bi::value<std::string>, boost::_bi::value<std::string>, boost::_bi::value<boost::function<void ()> >, boost::_bi::value<impala::ThreadDebugInfo*>, boost::_bi::value<impala::Promise<long, (impala::PromiseMode)0>*> >::operator()<void (*)(std::string const&, std::string const&, boost::function<void ()>, impala::ThreadDebugInfo const*, impala::Promise<long, (impala::PromiseMode)0>*), boost::_bi::list0>(boost::_bi::type<void>, void (*&)(std::string const&, std::string const&, boost::function<void ()>, impala::ThreadDebugInfo const*, impala::Promise<long, (impala::PromiseMode)0>*), boost::_bi::list0&, int) (this=0xe7399c0, f=@0xe7399b8: 0x218540c <impala::Thread::SuperviseThread(std::string const&, std::string const&, boost::function<void ()>, impala::ThreadDebugInfo const*, impala::Promise<long, (impala::PromiseMode)0>*)>, a=...) at /data/jenkins/workspace/impala-private-parameterized/Impala-Toolchain/boost-1.57.0-p3/include/boost/bind/bind.hpp:525
      #17 0x000000000218d9b7 in boost::_bi::bind_t<void, void (*)(std::string const&, std::string const&, boost::function<void ()>, impala::ThreadDebugInfo const*, impala::Promise<long, (impala::PromiseMode)0>*), boost::_bi::list5<boost::_bi::value<std::string>, boost::_bi::value<std::string>, boost::_bi::value<boost::function<void ()> >, boost::_bi::value<impala::ThreadDebugInfo*>, boost::_bi::value<impala::Promise<long, (impala::PromiseMode)0>*> > >::operator()() (this=0xe7399b8) at /data/jenkins/workspace/impala-private-parameterized/Impala-Toolchain/boost-1.57.0-p3/include/boost/bind/bind_template.hpp:20
      #18 0x000000000218d97a in boost::detail::thread_data<boost::_bi::bind_t<void, void (*)(std::string const&, std::string const&, boost::function<void ()>, impala::ThreadDebugInfo const*, impala::Promise<long, (impala::PromiseMode)0>*), boost::_bi::list5<boost::_bi::value<std::string>, boost::_bi::value<std::string>, boost::_bi::value<boost::function<void ()> >, boost::_bi::value<impala::ThreadDebugInfo*>, boost::_bi::value<impala::Promise<long, (impala::PromiseMode)0>*> > > >::run() (this=0xe739800) at /data/jenkins/workspace/impala-private-parameterized/Impala-Toolchain/boost-1.57.0-p3/include/boost/thread/detail/thread.hpp:116
      #19 0x000000000343e87a in thread_proxy ()
      #20 0x00007f2d7ef73e25 in start_thread () from /lib64/libpthread.so.0
      #21 0x00007f2d7eca134d in clone () from /lib64/libc.so.6
      

      Note the offending change (IMPALA-7213) is proposed to be deferred out of Impala 3.1.0 release so marking the affected version to Impala 3.2.0 only.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            kwho Michael Ho
            kwho Michael Ho
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment