[IMPALA-7522] milliseconds_add() can lead to overflow / DCHECK

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Impala 2.3.0
• Fix Version/s: Impala 3.1.0
• Component/s: Backend
• Labels: correctness timestamp
• Target Version: Impala 3.1.0
• Epic Color: ghx-label-4
• Assignee: Csaba Ringhofer
• Reporter: Csaba Ringhofer
• Created: 04/Sep/18 11:35
• Updated: 10/Sep/18 16:00
• Resolved: 07/Sep/18 14:29

Description

select milliseconds_add("1970-01-01", -10000000000000);
release build: result = 2237-09-01 05:47:53.709551616 (should be 1653-02-10 06:13:20)
debug build: timestamp-functions-ir.cc:740] Check failed: result_value < input_value (2237-09-01 05:47:53.709551616 vs. 1970-01-01 00:00:00)

seconds/microseconds_add work correctly with the same timestamp

Issue Links

• relates to: IMPALA-1675 Timestamp: Adding/subtracting very large time intervals to timestamps produces incorrect result