[IMPALA-7376] Impala hits a DCHECK if a fragment instance fails to initialize the filter bank

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: Impala 3.1.0
• Component/s: Backend
• Labels: crash
• Epic Color: ghx-label-5
• Assignee: Sailesh Mukil
• Reporter: Sailesh Mukil
• Created: 31/Jul/18 21:23
• Updated: 08/Aug/18 18:48
• Resolved: 08/Aug/18 18:48

Description

While Prepare()-ing a fragment instance, if we fail to initialize the runtime filter bank, we will exit FIS::Prepare() without acquiring a thread token (AcquireThreadToken()):

https://github.com/apache/impala/blob/316b17ac55adb3d1deeb1289b4045688269b201d/be/src/runtime/fragment-instance-state.cc#L135-L139

FIS::Finalize() is called always regardless of whether the fragment instance succeeded or failed. And FIS::Finalize() tries to ReleaseThreadToken() even though it might not have gotten acquired:
https://github.com/apache/impala/blob/316b17ac55adb3d1deeb1289b4045688269b201d/be/src/runtime/fragment-instance-state.cc#L464

, causing a DCHECK to be hit.

This was found while I was adding global debug actions (IMPALA-7046) to the FIS.