[IMPALA-6997] Query execution should notice UDF MemLimitExceeded errors more quickly

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Impala 2.13.0
• Fix Version/s: Impala 2.13.0, Impala 3.1.0
• Component/s: Backend
• Target Version: Impala 2.13.0
• Epic Color: ghx-label-8
• Assignee: Joe McDonnell
• Reporter: Joe McDonnell
• Created: 08/May/18 22:35
• Updated: 31/May/18 16:30
• Resolved: 31/May/18 16:30

Description

When a UDF hits a memory limit, it calls RuntimeState::SetMemLimitExceeded() which sets the query status, but it has no way of returning status directly. It relies on the caller checking status periodically.

HdfsTableSink::Send() checks for errors by calling RuntimeState::CheckQueryState() once at the beginning. If it is evaluating a UDF and that UDF hits the memory limit, it will need to process the whole RowBatch before it aborts the query. This could be 1024 rows and each row may hit a memory limit in that UDF. Other locations that process UDFs may be processing considerably more rows.

There are two general approaches:

1. Code locations should check for status more frequently and thus abort faster after a RuntimeState::SetMemLImitExceeded() call.
2. RuntimeState::SetMemLimitExceeded() should be substantially cheaper, allowing the rows to be processed faster.

RuntimeState::SetMemLimitExceeded() currently calls MemTracker::MemLimitExceeded() unconditionally. It then checks to see if it should update query_status_ (i.e. query_status_ is currently ok). Then it logs this error. This is wasteful, because MemTracker::MemLimitExceeded() is not a cheap function, and this is flooding the log for each row. RuntimeState::SetMemLimitExceeded() should check status before running MemTracker::MemoryLimitExceeded(). If query_status_ is already not ok, it can avoid the cost of the dump and logging.

Issue Links

• duplicates: IMPALA-6996 PartitionedAggregationNode::Close() should not dump stack trace
• is related to: IMPALA-6996 PartitionedAggregationNode::Close() should not dump stack trace
• relates to: IMPALA-2399 Cleanup/rethink QueryMaintenance() calls in the BE.