Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-6993

Don't print status stack trace when propagating thrift status in Coordinator::BackendState::Exec()

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • Impala 3.0
    • Impala 2.13.0, Impala 3.1.0
    • Backend
    • None

    Description

      We should use Status::Expected() here, just like it's used above. The stack trace isn't interesting and the error is expected once we get down this path. (I'm not sure why we don't just use exec_status though, but presumably the prefix was added for a reason).

      Status exec_status = Status(thrift_result.status);
      if (!exec_status.ok()) {
        const string& err_msg = Substitute(ERR_TEMPLATE, PrintId(query_id_),
        exec_status.msg().GetFullMessageDetails());
        VLOG_QUERY << err_msg;
        status_ = Status(err_msg);
        return;
      }
      

      Attachments

        Activity

          People

            dhecht Daniel Hecht
            dhecht Daniel Hecht
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: