Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-6878

SentryServicePinger should not print stacktrace at every retry

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: Impala 3.0, Impala 2.12.0
    • Fix Version/s: Impala 3.0, Impala 2.12.0
    • Component/s: Infrastructure
    • Labels:
      None
    • Epic Color:
      ghx-label-2

      Description

      The stack trace looks like this and is misleading as to whether the service started successfully or not:

      18/04/18 12:03:23 INFO transport.SentryTransportPool: Creating pool for localhost with default port 30911
      18/04/18 12:03:23 INFO transport.SentryTransportPool: Adding endpoint localhost:30911
      18/04/18 12:03:23 INFO transport.SentryTransportPool: Connection pooling is enabled
      18/04/18 12:03:23 ERROR transport.SentryTransportPool: Failed to obtain transport for localhost:30911: java.net.ConnectException: Connection refused (Connection refused)
      18/04/18 12:03:23 ERROR transport.RetryClientInvocationHandler: Failed to connect
      sentry.org.apache.thrift.transport.TTransportException: java.net.ConnectException: Connection refused (Connection refused)
      	at sentry.org.apache.thrift.transport.TSocket.open(TSocket.java:226)
      	at sentry.org.apache.sentry.core.common.transport.SentryTransportFactory.connectToServer(SentryTransportFactory.java:99)
      	at sentry.org.apache.sentry.core.common.transport.SentryTransportFactory.getTransport(SentryTransportFactory.java:86)
      	at sentry.org.apache.sentry.core.common.transport.SentryTransportPool$PoolFactory.create(SentryTransportPool.java:302)
      	at sentry.org.apache.sentry.core.common.transport.SentryTransportPool$PoolFactory.create(SentryTransportPool.java:271)
      	at org.apache.commons.pool2.BaseKeyedPooledObjectFactory.makeObject(BaseKeyedPooledObjectFactory.java:62)
      	at org.apache.commons.pool2.impl.GenericKeyedObjectPool.create(GenericKeyedObjectPool.java:1041)
      	at org.apache.commons.pool2.impl.GenericKeyedObjectPool.borrowObject(GenericKeyedObjectPool.java:380)
      	at org.apache.commons.pool2.impl.GenericKeyedObjectPool.borrowObject(GenericKeyedObjectPool.java:279)
      	at sentry.org.apache.sentry.core.common.transport.SentryTransportPool.getTransport(SentryTransportPool.java:183)
      	at org.apache.sentry.provider.db.service.thrift.SentryPolicyServiceClientDefaultImpl.connect(SentryPolicyServiceClientDefaultImpl.java:90)
      	at sentry.org.apache.sentry.core.common.transport.RetryClientInvocationHandler.connect(RetryClientInvocationHandler.java:141)
      	at sentry.org.apache.sentry.core.common.transport.RetryClientInvocationHandler.invokeImpl(RetryClientInvocationHandler.java:90)
      	at sentry.org.apache.sentry.core.common.transport.SentryClientInvocationHandler.invoke(SentryClientInvocationHandler.java:41)
      	at com.sun.proxy.$Proxy5.listAllRoles(Unknown Source)
      	at org.apache.impala.util.SentryUtil.listRoles(SentryUtil.java:52)
      	at org.apache.impala.util.SentryPolicyService.listAllRoles(SentryPolicyService.java:398)
      	at org.apache.impala.testutil.SentryServicePinger.main(SentryServicePinger.java:75)
      Caused by: java.net.ConnectException: Connection refused (Connection refused)
      	at java.net.PlainSocketImpl.socketConnect(Native Method)
      	at java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:350)
      	at java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:206)
      	at java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:188)
      	at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
      	at java.net.Socket.connect(Socket.java:589)
      	at sentry.org.apache.thrift.transport.TSocket.open(TSocket.java:221)
      	... 17 more
      18/04/18 12:03:26 ERROR transport.SentryTransportPool: Failed to obtain transport for localhost:30911: java.net.ConnectException: Connection refused (Connection refused)
      18/04/18 12:03:26 ERROR transport.RetryClientInvocationHandler: Failed to connect
      sentry.org.apache.thrift.transport.TTransportException: java.net.ConnectException: Connection refused (Connection refused)
      	at sentry.org.apache.thrift.transport.TSocket.open(TSocket.java:226)
      	at sentry.org.apache.sentry.core.common.transport.SentryTransportFactory.connectToServer(SentryTransportFactory.java:99)
      	at sentry.org.apache.sentry.core.common.transport.SentryTransportFactory.getTransport(SentryTransportFactory.java:86)
      	at sentry.org.apache.sentry.core.common.transport.SentryTransportPool$PoolFactory.create(SentryTransportPool.java:302)
      	at sentry.org.apache.sentry.core.common.transport.SentryTransportPool$PoolFactory.create(SentryTransportPool.java:271)
      	at org.apache.commons.pool2.BaseKeyedPooledObjectFactory.makeObject(BaseKeyedPooledObjectFactory.java:62)
      	at org.apache.commons.pool2.impl.GenericKeyedObjectPool.create(GenericKeyedObjectPool.java:1041)
      	at org.apache.commons.pool2.impl.GenericKeyedObjectPool.borrowObject(GenericKeyedObjectPool.java:380)
      	at org.apache.commons.pool2.impl.GenericKeyedObjectPool.borrowObject(GenericKeyedObjectPool.java:279)
      	at sentry.org.apache.sentry.core.common.transport.SentryTransportPool.getTransport(SentryTransportPool.java:183)
      	at org.apache.sentry.provider.db.service.thrift.SentryPolicyServiceClientDefaultImpl.connect(SentryPolicyServiceClientDefaultImpl.java:90)
      	at sentry.org.apache.sentry.core.common.transport.RetryClientInvocationHandler.connect(RetryClientInvocationHandler.java:141)
      	at sentry.org.apache.sentry.core.common.transport.RetryClientInvocationHandler.invokeImpl(RetryClientInvocationHandler.java:90)
      	at sentry.org.apache.sentry.core.common.transport.SentryClientInvocationHandler.invoke(SentryClientInvocationHandler.java:41)
      	at com.sun.proxy.$Proxy5.listAllRoles(Unknown Source)
      	at org.apache.impala.util.SentryUtil.listRoles(SentryUtil.java:52)
      	at org.apache.impala.util.SentryPolicyService.listAllRoles(SentryPolicyService.java:398)
      	at org.apache.impala.testutil.SentryServicePinger.main(SentryServicePinger.java:75)
      Caused by: java.net.ConnectException: Connection refused (Connection refused)
      	at java.net.PlainSocketImpl.socketConnect(Native Method)
      	at java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:350)
      	at java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:206)
      	at java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:188)
      	at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
      	at java.net.Socket.connect(Socket.java:589)
      	at sentry.org.apache.thrift.transport.TSocket.open(TSocket.java:221)
      	... 17 more
      18/04/18 12:03:29 ERROR transport.SentryTransportPool: Failed to obtain transport for localhost:30911: java.net.ConnectException: Connection refused (Connection refused)
      18/04/18 12:03:29 ERROR transport.RetryClientInvocationHandler: Failed to connect
      sentry.org.apache.thrift.transport.TTransportException: java.net.ConnectException: Connection refused (Connection refused)
      	at sentry.org.apache.thrift.transport.TSocket.open(TSocket.java:226)
      	at sentry.org.apache.sentry.core.common.transport.SentryTransportFactory.connectToServer(SentryTransportFactory.java:99)
      	at sentry.org.apache.sentry.core.common.transport.SentryTransportFactory.getTransport(SentryTransportFactory.java:86)
      	at sentry.org.apache.sentry.core.common.transport.SentryTransportPool$PoolFactory.create(SentryTransportPool.java:302)
      	at sentry.org.apache.sentry.core.common.transport.SentryTransportPool$PoolFactory.create(SentryTransportPool.java:271)
      	at org.apache.commons.pool2.BaseKeyedPooledObjectFactory.makeObject(BaseKeyedPooledObjectFactory.java:62)
      	at org.apache.commons.pool2.impl.GenericKeyedObjectPool.create(GenericKeyedObjectPool.java:1041)
      	at org.apache.commons.pool2.impl.GenericKeyedObjectPool.borrowObject(GenericKeyedObjectPool.java:380)
      	at org.apache.commons.pool2.impl.GenericKeyedObjectPool.borrowObject(GenericKeyedObjectPool.java:279)
      	at sentry.org.apache.sentry.core.common.transport.SentryTransportPool.getTransport(SentryTransportPool.java:183)
      	at org.apache.sentry.provider.db.service.thrift.SentryPolicyServiceClientDefaultImpl.connect(SentryPolicyServiceClientDefaultImpl.java:90)
      	at sentry.org.apache.sentry.core.common.transport.RetryClientInvocationHandler.connect(RetryClientInvocationHandler.java:141)
      	at sentry.org.apache.sentry.core.common.transport.RetryClientInvocationHandler.invokeImpl(RetryClientInvocationHandler.java:90)
      	at sentry.org.apache.sentry.core.common.transport.SentryClientInvocationHandler.invoke(SentryClientInvocationHandler.java:41)
      	at com.sun.proxy.$Proxy5.listAllRoles(Unknown Source)
      	at org.apache.impala.util.SentryUtil.listRoles(SentryUtil.java:52)
      	at org.apache.impala.util.SentryPolicyService.listAllRoles(SentryPolicyService.java:398)
      	at org.apache.impala.testutil.SentryServicePinger.main(SentryServicePinger.java:75)
      Caused by: java.net.ConnectException: Connection refused (Connection refused)
      	at java.net.PlainSocketImpl.socketConnect(Native Method)
      	at java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:350)
      	at java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:206)
      	at java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:188)
      	at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
      	at java.net.Socket.connect(Socket.java:589)
      	at sentry.org.apache.thrift.transport.TSocket.open(TSocket.java:221)
      	... 17 more
      18/04/18 12:03:32 INFO testutil.SentryServicePinger: Sentry Service ping succeeded.
      

        Attachments

          Activity

            People

            • Assignee:
              fredyw Fredy Wijaya
              Reporter:
              fredyw Fredy Wijaya
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: