Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-6603

Fix output for cherry-picking job

    XMLWordPrintableJSON

Details

    • ghx-label-3

    Description

      The cherrypick-2.x-and-test job builds a line to display as the description of the build in Jenkins. It should contain all commits that were considered. Currently we build it like so:

      git log --format="%s" -z HEAD ^origin/2.x  | sed -e 's/\x00/<br>/' -e 's/^/JENKINS: /'
      

      I've seen this cause issues once where not all instances of \x00 were replaced, which then results in unprintable characters in the Jenkins build description. This in turn can trip up other tooling.

      Additionally, this prints a <br> at the end, causing the next line of the output to be appended, which usually is + touch found-cherrypicks.

      To this this, the line should look like this:

      git log --format="%s" -z HEAD ^origin/2.x | sed -e 's/\x00$/\n/' -e 's/\x00/<br>/g' -e 's/^/JENKINS: /'
      

      Attachments

        Activity

          People

            lv Lars Volker
            lv Lars Volker
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: