[IMPALA-6543] Limit RowBatch serialization size to INT_MAX

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Impala 2.11.0, Impala 2.12.0
• Fix Version/s: Impala 2.12.0
• Component/s: Backend
• Target Version: Impala 2.12.0
• Epic Color: ghx-label-6
• Assignee: Joe McDonnell
• Reporter: Joe McDonnell
• Created: 20/Feb/18 17:49
• Updated: 28/Feb/18 16:19
• Resolved: 28/Feb/18 16:19

Description

A RowBatch does not support serializing an uncompressed size of greater than INT_MAX. The serialization format relies on tuple offsets of type of int32, so they cannot address greater than INT_MAX.

On debug builds, a DCHECK in SerializeInternal() fires when the size exceeds INT_MAX. On release builds, LZ4's limitation of INT_MAX on the size of uncompressed size avoids any issue. The serialization codepath should protect itself and avoid this issue on debug builds.