[IMPALA-6335] Remove the unnecessary decorator "pytest.mark.execute_serially" from tests which can be run in parallel

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Impala 2.10.0
• Fix Version/s: Impala 3.1.0
• Component/s: Infrastructure
• Labels: newbie
• Epic Color: ghx-label-9
• Assignee: Todd Lipcon
• Reporter: Jin Chul Kim
• Created: 16/Dec/17 13:10
• Updated: 08/Aug/18 07:26
• Resolved: 08/Aug/18 03:39

Description

Regarding the decorator "pytest.mark.execute_serially", I saw all the test cases are marked as execute_serially in tests/shell/test_shell_interactive.py. I guess a few tests should be run exclusively, but the other tests do not require the serial option. What do you think about this? I think we should consider to use the decorator when adding test cases. Minimized serial run can help to reduce overall test running time by parallelism.

I think the following cases do not require the decorator.
a. Check consistency from test result
b. Test query cancellation
c. Test shell options which are effective on local shell

> From Tim's comment:
I think you're right that many of the shell tests don't inherently require to be executed serially. Some of them would require work to execute in parallel, particularly the ones that inspect files like .impalahistory and tests that check the values of global impala daemon metrics.

Issue Links

• relates to: IMPALA-7289 Change shell tests to ignore ~/.impalarc