Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-6299

IRBuilder codegen should using LLVMCodeGen::cpu_attrs instead of CpuInfo to determine valid instructions

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • Impala 3.1.0
    • Backend
    • ghx-label-1

    Description

      This came out of a discussion on this code review: https://gerrit.cloudera.org/#/c/8802/

      The idea is that IRBuilder code that emits intrinsics should only do so if we have those CPU features enabled in LLVM. Otherwise codegen will fail to compile the emitted instructions.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            poojanilangekar Pooja Nilangekar
            tarmstrong Tim Armstrong
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment