[IMPALA-6259] Remove workaround for posix_memalign in SystemAllocator after LLVM 6.0 upgrade

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: Impala 2.11.0
• Component/s: Backend
• Target Version: Product Backlog
• Epic Color: ghx-label-6
• Assignee: Sahil Takiar
• Reporter: Tim Armstrong
• Created: 29/Nov/17 01:22
• Updated: 05/Feb/20 01:17

Description

Once we upgrade to LLVM 5.0 we should be able to remove a workaround for https://bugs.llvm.org/show_bug.cgi?id=32968 :

#ifdef ADDRESS_SANITIZER
  // Workaround ASAN bug where posix_memalign returns 0 even when allocation fails.
  // It should instead return ENOMEM. See https://bugs.llvm.org/show_bug.cgi?id=32968.
  if (rc == 0 && *buffer_mem == nullptr && len != 0) rc = ENOMEM;
#endif

Issue Links

• depends upon: IMPALA-5980 Upgrade to LLVM 5.0.1