[IMPALA-6146] Rethink HdfsTextScanner::FillByteBuffer() extension point

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Won't Fix
• Component/s: Backend
• Epic Color: ghx-label-5
• Assignee: Unassigned
• Reporter: Tim Armstrong
• Created: 02/Nov/17 19:51
• Updated: 14/May/20 19:25
• Resolved: 14/May/20 19:25

Description

The HDFS text scanner allows extension via subclassing and overriding FillByteBuffer(). FillByteBuffer() is poorly encapsulated from the rest of the text scanner implementation - it modifies several member variables, which makes it hard to fix bugs like IMPALA-6137. We should come up a better defined interface.