Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-5599

Clean up non-TIMESTAMP usages of TimestampValue

    Details

    • Epic Color:
      ghx-label-3

      Description

      There are numerous places in the BE code where TimestampValue is used for non-TIMESTAMP related purposes, e.g. printing the current time in log messages and the web UI/profiles.

      The following is a good place to start:

      mj@mj-desktop:~/dev/Impala/be/src/service$ git grep TimestampValue
      client-request-state.cc:    start_time_(TimestampValue::LocalTime()) {
      client-request-state.cc:  end_time_ = TimestampValue::LocalTime();
      client-request-state.h:  const TimestampValue& start_time() const { return start_time_; }
      client-request-state.h:  const TimestampValue& end_time() const { return end_time_; }
      client-request-state.h:  TimestampValue start_time_, end_time_;
      impala-http-handler.cc:  const TimestampValue& end_timestamp =
      impala-http-handler.cc:      record.end_time.HasDate() ? record.end_time : TimestampValue::LocalTime();
      impala-http-handler.cc:    TimestampValue local_start_time = TimestampValue::FromUnixTime(
      impala-http-handler.cc:    TimestampValue local_last_accessed = TimestampValue::FromUnixTime(
      impala-server.cc:      TimestampValue::LocalTime().ToString());
      impala-server.cc:  query_ctx->__set_now_string(TimestampValue::LocalTime().ToString());
      impala-server.cc:           << TimestampValue::FromUnixTime(last_time_s).ToString() << ").";
      impala-server.cc:                  << TimestampValue::FromUnixTime(last_accessed_ms / 1000).ToString();
      impala-server.cc:              << TimestampValue::FromUnixTime(last_active_s).ToString();
      impala-server.h:    TimestampValue start_time, end_time;
      

      Use of TimestampValue should be removed.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                zoram Zoram Thanga
                Reporter:
                mjacobs Matthew Jacobs
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: