Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-5532

Don't heap-allocate compressor objects in RowBatch

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • Impala 2.10.0
    • Impala 2.10.0
    • Backend
    • None
    • ghx-label-4

    Description

      Every call to RowBatch::RowBatch(..., const TRowBatch&, ...) or RowBatch::Serialize() creates a (de)compressor object. That uses the Codec::CreateCompressor() interface which returns a pointer to a Codec object, so that the virtual compression interface can be used.

      However, we always use LZ4 compression, and so needlessly heap-allocate the compressor objects to get the advantage of implementation hiding which we don't actually need. We should just declare a stack-allocated LZ4 (de)compressor when needed.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            henryr Henry Robinson
            henryr Henry Robinson
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment