[IMPALA-5518] Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Impala 2.2
• Fix Version/s: Impala 3.0, Impala 2.12.0
• Epic Color: ghx-label-6
• Assignee: Michael Ho
• Reporter: Henry Robinson
• Created: 15/Jun/17 19:02
• Updated: 20/Feb/18 17:09
• Resolved: 20/Feb/18 08:14

Description

The DataStreamSender allocates row batches in whatever thread handles the TransmitData() RPC, but then deallocates them in the fragment instance thread.

That is an anti-pattern for tcmalloc. Instead we should see if we can recycle the row batches where possible.

We could try to 'pin' row batches to service threads, and give them each a thread-local ability to reallocate row batch data - the key is ensuring that the deallocations happen on the same thread, so we can't just give each sender a list of row batches because that sender may be handled by different service pool threads.

Alternatively we can try to cut down on the number of allocations, but that's hard to do with cross-thread coordination.

Issue Links

• blocks: IMPALA-5528 tcmalloc contention much higher with concurrency after KRPC patch
• is blocked by: IMPALA-6519 Allow atomic allocation of an unreserved buffer
• is related to: IMPALA-6359 Blocking in Service threads due to tcmalloc contention due to memory allocations for RowBatch::Deserialize