Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-5391

Cannot compile UDFs with older GCC versions

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Impala 2.9.0
    • Fix Version/s: Impala 2.9.0
    • Component/s: Backend
    • Labels:
      None

      Description

      uda-test-harness.h doesn't compile with older versions of GCC. This is unhelpful when trying to build Impala UDFs using the native compilers on older OS versions.

      In file included from /var/lib/jenkins/workspace/impala-udf-dev-xplatform/label/systest-slave/impala-udf-samples/uda-sample-test.cc:18:0:
      /usr/include/impala_udf/uda-test-harness.h:47:35: error: ‘virtual impala_udf::UdaTestHarnessBase<RESULT, INTERMEDIATE>::~UdaTestHarnessBase()’ declared virtual cannot be defaulted in the class body
      /usr/include/impala_udf/uda-test-harness.h:150:31: error: ‘virtual impala_udf::UdaTestHarness<RESULT, INTERMEDIATE, INPUT>::~UdaTestHarness()’ declared virtual cannot be defaulted in the class body
      

        Activity

        Hide
        tarmstrong Tim Armstrong added a comment -

        IMPALA-5391: remove C++11 from UDF header

        This replaces the C+11 idiom with equivalent C+98 code. The code was
        added to address a clang-tidy warning about missing virtual
        destructors, which the new code should also address.

        Change-Id: Ic10906027e3644e4d42ad20fcd6abda1c24fefa6
        Reviewed-on: http://gerrit.cloudera.org:8080/7024
        Reviewed-by: Henry Robinson <henry@cloudera.com>
        Tested-by: Impala Public Jenkins

        Show
        tarmstrong Tim Armstrong added a comment - IMPALA-5391 : remove C++11 from UDF header This replaces the C+ 11 idiom with equivalent C +98 code. The code was added to address a clang-tidy warning about missing virtual destructors, which the new code should also address. Change-Id: Ic10906027e3644e4d42ad20fcd6abda1c24fefa6 Reviewed-on: http://gerrit.cloudera.org:8080/7024 Reviewed-by: Henry Robinson <henry@cloudera.com> Tested-by: Impala Public Jenkins

          People

          • Assignee:
            tarmstrong Tim Armstrong
            Reporter:
            tarmstrong Tim Armstrong
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development