Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-5340

Query profile and debug webpage can disagree about 'Query State'

    Details

    • Epic Color:
      ghx-label-3

      Description

      The problem is that even though both the query profile and the /queries debug web page set 'Query State' from the value ClientRequestState::query_state_, the debug web page always takes the current value, whereas the value in the profile is only updated at particular points during execution.

      This can lead to a situation where the profile's 'Query State' is stale and doesn't match the one in the debug web page, which is confusing.

        Activity

        Hide
        twmarshall Thomas Tauber-Marshall added a comment -

        commit ee9fbeca9041349d3532d315bf07e77d784a846d
        Author: Thomas Tauber-Marshall <tmarshall@cloudera.com>
        Date: Thu May 18 12:50:48 2017 -0700

        IMPALA-5340: Query profile displays stale query state

        Previously, updates to the query state in ClientRequestState were
        not immediately reflected in the query profile, potentially
        leading to the profile showing an incorrect state for an extended
        perioud during execution.

        In particular, queries were being shown in the 'CREATED' state
        long after they had started 'RUNNING'.

        The fix is to update the profile whenever the state is updated.

        Testing:

        • Extended existing hs2 tests and added a beeswax test to check
          for expected query states in the profile

        Change-Id: I952319b7308a24d4e2dff924199c0c771bce25b3
        Reviewed-on: http://gerrit.cloudera.org:8080/6923
        Reviewed-by: Dan Hecht <dhecht@cloudera.com>
        Reviewed-by: Thomas Tauber-Marshall <tmarshall@cloudera.com>
        Tested-by: Impala Public Jenkins

        Show
        twmarshall Thomas Tauber-Marshall added a comment - commit ee9fbeca9041349d3532d315bf07e77d784a846d Author: Thomas Tauber-Marshall <tmarshall@cloudera.com> Date: Thu May 18 12:50:48 2017 -0700 IMPALA-5340 : Query profile displays stale query state Previously, updates to the query state in ClientRequestState were not immediately reflected in the query profile, potentially leading to the profile showing an incorrect state for an extended perioud during execution. In particular, queries were being shown in the 'CREATED' state long after they had started 'RUNNING'. The fix is to update the profile whenever the state is updated. Testing: Extended existing hs2 tests and added a beeswax test to check for expected query states in the profile Change-Id: I952319b7308a24d4e2dff924199c0c771bce25b3 Reviewed-on: http://gerrit.cloudera.org:8080/6923 Reviewed-by: Dan Hecht <dhecht@cloudera.com> Reviewed-by: Thomas Tauber-Marshall <tmarshall@cloudera.com> Tested-by: Impala Public Jenkins

          People

          • Assignee:
            twmarshall Thomas Tauber-Marshall
            Reporter:
            twmarshall Thomas Tauber-Marshall
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development