[IMPALA-5322] Potential crash in Frontend & Catalog JNI startup

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: Impala 2.8.0
• Fix Version/s: Impala 2.9.0
• Component/s: Backend
• Epic Color: ghx-label-5
• Assignee: Bharath Vissapragada
• Reporter: Bharath Vissapragada
• Created: 14/May/17 17:36
• Updated: 14/May/17 17:37
• Resolved: 14/May/17 17:37

Description

 cfg.__set_load_auth_to_local_rules(FLAGS_load_auth_to_local_rules);
  cfg.__set_principal(FLAGS_principal);
  cfg.__set_impala_log_lvl(FlagToTLogLevel(FLAGS_v));
  cfg.__set_non_impala_java_vlog(FlagToTLogLevel(FLAGS_non_impala_java_vlog));
  cfg.__set_inc_stats_size_limit_bytes(FLAGS_inc_stats_size_limit_bytes);
  cfg.__set_lineage_event_log_dir(FLAGS_lineage_event_log_dir);
  cfg.__set_local_library_path(FLAGS_local_library_dir);
  cfg.__set_kudu_operation_timeout_ms(FLAGS_kudu_operation_timeout_ms);
  JniLocalFrame jni_frame; <---
  RETURN_IF_ERROR(jni_frame.push(jni_env));  <----
  RETURN_IF_ERROR(SerializeThriftMsg(jni_env, &cfg, cfg_bytes));
  return Status::OK();

We use a local frame that could be GC'ed by the JVM. There is no need to use it. This was found in testing where we instantiate multiple fe instances.